ref: generalize acceleration structures #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-volume-finder
branch
2 times, most recently
from
1dad838 to
945980f
Compare
|
niermann999
force-pushed
the
feat-volume-finder
branch
3 times, most recently
from
bfc4bde to
c4fc8a1
Compare
niermann999
changed the title
niermann999
force-pushed
the
feat-volume-finder
branch
from
c4fc8a1 to
035a8e2
Compare
niermann999
changed the title
niermann999
force-pushed
the
feat-volume-finder
branch
2 times, most recently
from
2c2a592 to
42588cc
Compare
niermann999
force-pushed
the
feat-volume-finder
branch
3 times, most recently
from
ed1d019 to
ac50d9b
Compare
niermann999
force-pushed
the
feat-volume-finder
branch
from
ac50d9b to
4659811
Compare
stephenswat
approved these changes
Sep 5, 2025
niermann999
force-pushed
the
feat-volume-finder
branch
from
4659811 to
2b81f2b
Compare
Collaborator
Author
|
main new Unfortunately, this seems to slow things down a bit and needs further investigation |
niermann999
force-pushed
the
feat-volume-finder
branch
from
2b81f2b to
9a9b471
Compare
|
niermann999
force-pushed
the
feat-volume-finder
branch
3 times, most recently
from
53f96cf to
36a3e26
Compare
niermann999
force-pushed
the
feat-volume-finder
branch
from
36a3e26 to
7b1a04c
Compare
Collaborator
Author
|
The latest benchmarks actually show no performance hit anymore: Unblocking |
niermann999
added
priority: high
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the acceleration data structure implementation, so that also volume search data structures can be added in the future. In particular, the tracking volume and navigator can now call into surface and volume search data structures. The current surface accelerators are cleaned up and adapted to fulfill the new
acceleratorconcept.For this, the grid has been split into the 'utility' grid, which is also used by the material maps, and the spatial grid, which is now dedicated to spacial searches of contained surfaces or volumes. Both grid accelerator types (surface and volume) can now be added to the detector accelerator store. The spatial grid is equipped with a dedicated grid collection, which will make it easier in the future to add the mask data of the representing surface (this will need to be added to stay in sync with ACTS).
The actual volume accelerator data structures and their IO will be added in a future PR.